Test case for the issue 280 #284
Conversation
| const subject = await render(MainComponent, {imports: [AppRoutingModule, RouterTestingModule]}); | ||
| await subject.navigate('/'); | ||
|
|
||
| expect(await screen.findByText('Navigate')).toBeTruthy(); |
There was a problem hiding this comment.
I left extra expects in place, showing that there is successful navigation to second page.
I typically don't do that in my tests, please let me know if you want me to remove extras.
Thank you.
| const subject = await render(MainComponent, {imports: [AppRoutingModule, RouterTestingModule]}); | ||
| await subject.navigate('/'); | ||
|
|
||
| expect(await screen.findByText('Navigate')).toBeTruthy(); |
No problem, made changes, let me know what you think. Thanks! |
|
@all-contributors please add @meirka for bug, tests |
|
I've put up a pull request to add @meirka! 🎉 |
|
Oh yikes, it seems to be failing 😲 |
There was a problem hiding this comment.
Sorry to bother again, but could you comment this test out and make a new one that succeeds by using the following technique.
const router = TestBed.inject(Router);
router.initialNavigation();
And a tip, instead of toBeTruthy you can use toBeInTheDocument which makes it easier to read imho.
Sure, I can do that, but what's purpose? |
|
@meirka yea 😅 |
|
Sure, will do |
|
Done, let know if anything else, don't hesitate. |
Thank you for all the help, it was a pleasure! |
|
🎉 This PR is included in version 11.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.