Fix .cabal files so 'stack check' passes. #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LICENSE files for all packages. - Add descriptions for packages that were missing one. - Work around google/proto-lens#69 by symlinking third_party into tensorflow-proto.
blackgnezdo
reviewed
May 10, 2017
| , ../third_party/tensorflow/tensorflow/core/protobuf/config.proto | ||
| , ../third_party/tensorflow/tensorflow/core/protobuf/debug.proto | ||
| , ../third_party/tensorflow/tensorflow/core/util/event.proto | ||
| extra-source-files: third_party/tensorflow/tensorflow/core/framework/*.proto |
There was a problem hiding this comment.
How will this work for stand-alone cabal builds? Are you planning to include these files into the package?
There was a problem hiding this comment.
Yes, for this first release I was planning to include the .proto files in the tarball we upload to Hackage.
Longer-term I'd like to upload the generated *.hs files themselves, to avoid the dependency on protoc. But that will require more changes to Data.ProtoLens.Setup.
There was a problem hiding this comment.
(To clarify, this new setup causes the linked .proto files to be included in the tarball automatically.)
blackgnezdo
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensorflow-proto.