Skip to content

chore(rtl): clearly state that rtl and ltr cannot be mixed #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

ntacheva
Copy link
Contributor

No description provided.

@ntacheva ntacheva requested a review from a team June 28, 2024 12:53
@ntacheva ntacheva self-assigned this Jun 28, 2024
@ntacheva ntacheva requested a review from a team as a code owner June 28, 2024 12:53
@ntacheva ntacheva added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jun 28, 2024
Copy link
Contributor

Hello @ntacheva,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @dimodi's suggestions.

@radkostanev
Copy link
Member

Have we had such a request? In theory, there might be valid cases where one could intentionally mix these.

@dimodi dimodi merged commit 98762c3 into master Jul 12, 2024
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2235

@github-actions github-actions bot deleted the ntacheva-patch-1 branch July 12, 2024 09:04
NansiYancheva pushed a commit that referenced this pull request Aug 1, 2024
* chore(rtl): clearly state that rtl and ltr cannot be mixed

* Update globalization/rtl-support.md

Co-authored-by: Dimo Dimov <[email protected]>

* Update globalization/rtl-support.md

Co-authored-by: Dimo Dimov <[email protected]>

---------

Co-authored-by: Dimo Dimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants