Skip to content

kb(FileSelect): disable fileselect and change caption #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2024
Merged

kb(FileSelect): disable fileselect and change caption #1979

merged 4 commits into from
Mar 26, 2024

Conversation

Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Mar 19, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team March 19, 2024 12:51
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Mar 19, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner March 19, 2024 12:51
@github-actions GitHub Actions
Copy link
Contributor

Hello @Tsvetomir-Hr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

ikoevska
ikoevska approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic changes are required. You can merge after reviewing and addressing the comments. Re-request a review if you want me to look at this PR again.

@Tsvetomir-Hr Tsvetomir-Hr requested a review from ikoevska March 20, 2024 14:53
ikoevska
ikoevska approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note my comment on Line 33 and implement as needed. You can merge afterward. No further reviews required after that.

@xristianstefanov xristianstefanov merged commit 06cb03e into master Mar 26, 2024
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Here you are the link to your PR to production: 2003

@github-actions github-actions bot deleted the fileselect-kb-disable-onselect branch March 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikoevska ikoevska ikoevska approved these changes

Assignees

@Tsvetomir-Hr Tsvetomir-Hr

Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tsvetomir-Hr @ikoevska @xristianstefanov