Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign other types of artifacts #124

Closed
priyawadhwa opened this issue Jun 18, 2021 · 19 comments
Closed

Sign other types of artifacts #124

priyawadhwa opened this issue Jun 18, 2021 · 19 comments
Labels
area/s3c Issues or PRs that are related to Secure Software Supply Chain (S3C) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten

Comments

@priyawadhwa
Copy link
Contributor

Right now we only sign TaskRuns and OCI Images, but it would be cool to give users a way to sign other types of results (binaries, files, whatever)

@priyawadhwa priyawadhwa added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 18, 2021
@mattmoor
Copy link
Member

Two that immediately come to mind are PipelineRuns as well as Runs (for custom tasks cc @imjasonh).

It might also be prudent to better formalize the way image outputs are signed. I was spitballing this with @dlorenc a week or so ago, but this would be another great application of duck typing task/pipeline[1] input/output shapes (as I was playing with in mattmoor/mink motivated by CLI DevX).

[1] - From here on I'm going to say "task" when I really mean task, pipeline, or a user-defined custom task definition.

The general idea is that tooling (including some possible defined by Tekton upstream) would standardize around certain task signature "shapes". Imagine if tasks with outputs named like dev.tekton.imagedigest.* (strawman) could be interpreted as being image digest outputs?

These duck types aren't semantically meaningful to tekton/pipeline itself (like say pipeline resources were), but enable an extensibility model that puts the burden of adhering to such conventions on consuming tools (e.g. tkn, dashboard, chains).

Another aspect of wanting standardization of certain conventions is that we can start to make the catalog adhere to them so that folks can get a really nice OOTB experience.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@priyawadhwa
Copy link
Contributor Author

/reopen
/remove-lifecycle rotten

@tekton-robot
Copy link

@priyawadhwa: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xchapter7x
Copy link

/area s3c

@tekton-robot tekton-robot added the area/s3c Issues or PRs that are related to Secure Software Supply Chain (S3C) label Mar 4, 2022
@xchapter7x xchapter7x moved this to NEW in S3C Milestones Mar 4, 2022
@lcarva
Copy link
Contributor

lcarva commented Mar 24, 2022

TEP-84 is related to signing of PipelineRuns.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobcatfish
Copy link
Contributor

I think this might be being covered by the TEP-0109 structured results work by @ywluogg ?

/reopen

@tekton-robot tekton-robot reopened this Nov 30, 2022
@tekton-robot
Copy link

@bobcatfish: Reopened this issue.

In response to this:

I think this might be being covered by the TEP-0109 structured results work by @ywluogg ?

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywluogg
Copy link
Contributor

ywluogg commented Nov 30, 2022

Yeah I think if the binaries and the files captured in Intoto attestation can be signed by TEP 109

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobcatfish
Copy link
Contributor

For anyone looking for this functionality, the place it is currently documented is https://github.com/tektoncd/chains/blob/main/docs/intoto.md#structured-result-type-hinting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/s3c Issues or PRs that are related to Secure Software Supply Chain (S3C) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten
Projects
Status: NEW
Status: Done
Development

No branches or pull requests

7 participants