Fix priority range values for event listeners. #5194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to http://symfony.com/doc/master/reference/dic_tags.html, priority range is from -1024 to +1024.
|
I think we should remove the range in this section, as you can use whatever number you want. It doesn't limit you to a specific range. The core listeners are within the [-1024 ... 1024] range, but that doesn't have to say anything about your own listeners. |
Remove priority range.
Fix typo.
|
And your first doc contribution is now merged! Congratulations and thanks for submitting it. You'll get the "doc contributor" in some days :) Btw, a little tip for the next time: We don't get updates about new commits that are added to PRs. We'll notice updates quicker if you comment after it (which are notified to the repo followers). |
wouterj
added a commit
that referenced
this pull request
Apr 26, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #5194). Discussion ---------- Fix priority range values for event listeners. According to http://symfony.com/doc/master/reference/dic_tags.html, priority range is from -1024 to +1024. Commits ------- 2492952 Fix priority range values for event listeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://symfony.com/doc/master/reference/dic_tags.html, priority range is from -1024 to +1024.