-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Quick Tour] Fixed things found by the docbot #5189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They are useful when you need to set a success message before redirecting the | ||
user to another page (which will then show the message):: | ||
You can also store "flash messages" that will auto-delete after the next | ||
request. They are useful when you need to set a success message before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor error: two white spaces after request.
@wouterj excellent work! Congrats! I'm really looking forward to see the bot in action. |
Thanks for your quick review, @javiereguiluz! I've added this to the docbot reviewers and found a couple more occurences. Fixed them & pushed again ✔️ |
@wouterj shouldn't you fix the 2.3 branch first, and then fix 2.7 after merging 2.3 into it ? |
@stof thanks for noticing it. I've done the changes against 2.3, but it seems that I choose the wrong branch for the PR. So @weaverryan, in case you merge this PR, it should be switched to 2.3. |
@javiereguiluz you can try it yourself with a (very on-the-edge) release of the docbot: https://github.com/WouterJ/docbot |
I've merged this one now. If anyone spots something wrong, please create a PR fixing it :) |
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5189). Discussion ---------- [Quick Tour] Fixed things found by the docbot Found some time to get the docbot working again. Before showing it in action, we have to make sure the current docs comply with its standards. That means fixing a lot of too long lines, we have a very strict bot now :) Besides that, this PR also fixes some serial comma, wrong title case and other wrong usage. Commits ------- fd133c7 Fixed things found by the docbot
Found some time to get the docbot working again. Before showing it in action, we have to make sure the current docs comply with its standards. That means fixing a lot of too long lines, we have a very strict bot now :)
Besides that, this PR also fixes some serial comma, wrong title case and other wrong usage.