Skip to content

[Quick Tour] Fixed things found by the docbot #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Apr 17, 2015

Found some time to get the docbot working again. Before showing it in action, we have to make sure the current docs comply with its standards. That means fixing a lot of too long lines, we have a very strict bot now :)

Besides that, this PR also fixes some serial comma, wrong title case and other wrong usage.

They are useful when you need to set a success message before redirecting the
user to another page (which will then show the message)::
You can also store "flash messages" that will auto-delete after the next
request. They are useful when you need to set a success message before
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor error: two white spaces after request.

@javiereguiluz
Copy link
Member

@wouterj excellent work! Congrats! I'm really looking forward to see the bot in action.

@wouterj
Copy link
Member Author

wouterj commented Apr 17, 2015

Thanks for your quick review, @javiereguiluz! I've added this to the docbot reviewers and found a couple more occurences. Fixed them & pushed again ✔️

@stof
Copy link
Member

stof commented Apr 17, 2015

@wouterj shouldn't you fix the 2.3 branch first, and then fix 2.7 after merging 2.3 into it ?

@wouterj
Copy link
Member Author

wouterj commented Apr 17, 2015

@stof thanks for noticing it. I've done the changes against 2.3, but it seems that I choose the wrong branch for the PR.

So @weaverryan, in case you merge this PR, it should be switched to 2.3.

@wouterj wouterj changed the title Fixed things found by the docbot [Quick Tour] Fixed things found by the docbot Apr 19, 2015
@wouterj
Copy link
Member Author

wouterj commented Apr 19, 2015

@javiereguiluz you can try it yourself with a (very on-the-edge) release of the docbot: https://github.com/WouterJ/docbot

@wouterj
Copy link
Member Author

wouterj commented Apr 26, 2015

I've merged this one now. If anyone spots something wrong, please create a PR fixing it :)

wouterj added a commit that referenced this pull request Apr 26, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5189).

Discussion
----------

[Quick Tour] Fixed things found by the docbot

Found some time to get the docbot working again. Before showing it in action, we have to make sure the current docs comply with its standards. That means fixing a lot of too long lines, we have a very strict bot now :)

Besides that, this PR also fixes some serial comma, wrong title case and other wrong usage.

Commits
-------

fd133c7 Fixed things found by the docbot
@wouterj wouterj closed this Apr 26, 2015
@wouterj wouterj deleted the doc_fixes branch April 26, 2015 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants