Quick review of the Security book chapter #5090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -869,7 +871,8 @@ Checking to see if a User is Logged In (IS_AUTHENTICATED_FULLY) | |||
|
|
|||
| So far, you've checked access based on roles - those strings that start with | |||
| ``ROLE_`` and are assigned to users. But if you *only* want to check if a | |||
| user is logged in (you don't care about roles), then you can see ``IS_AUTHENTICATED_FULLY``:: | |||
| user is logged in (you don't care about roles), then you can see | |||
There was a problem hiding this comment.
Instead of you can see IS_AUTHENTICATED_FULLY:: I think it should be you can use IS_AUTHENTICATED_FULLY::
There was a problem hiding this comment.
Indeed, how did "see" slip in here.. :)
6fc64c0 to
65ba36d
Compare
|
Thank you guys! I've fixed the PR |
|
Yea, thanks Wouter! |
weaverryan
added a commit
that referenced
this pull request
Mar 25, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Quick review of the Security book chapter Just did a quick review of the Security book chapter. I wanted to make it use best practices, but found out that @weaverryan already did a great job at it :) | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 65ba36d Quick review of the Security book chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just did a quick review of the Security book chapter. I wanted to make it use best practices, but found out that @weaverryan already did a great job at it :)