Switched the first example to a static constructor method #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe having a non-static method for class instantiation is not something the documentation should encourage. It's much better to use a named constructor here (also note that `TestObject` class code isn't supplied).
|
yes, you're totally right! |
|
This looks reasonable to me. 👍 |
|
Sounds good to me - thanks Stepan! |
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
… (kix) This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5043). Discussion ---------- Switched the first example to a static constructor method I believe having a non-static method for class instantiation is not something the documentation should encourage. It's much better to use a named constructor here (also note that `TestObject` class code isn't supplied). Commits ------- 118513b Switched the first example to a static constructor method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe having a non-static method for class instantiation is not something the documentation should encourage. It's much better to use a named constructor here (also note that
TestObjectclass code isn't supplied).