Added a note about the class option of the services defined via factories #5018
Conversation
| .. note:: | ||
|
|
||
| When creating a service through a factory, the value chosen for the ``class`` | ||
| option has no actual effect since the final class only depends on the object |
There was a problem hiding this comment.
"has no effect on the resulted service, since the actual class name only depends on the object returned by the factory."
| @@ -68,6 +68,14 @@ class: | |||
|
|
|||
| $container->setDefinition('newsletter_manager', $definition); | |||
|
|
|||
| .. note:: | |||
|
|
|||
| When creating a service through a factory, the value chosen for the ``class`` | |||
There was a problem hiding this comment.
when using a factory to create services, the ....
There was a problem hiding this comment.
Much better! Thanks.
|
Looks good to me 👍 |
|
|
||
| When using a factory to create services, the value chosen for the ``class`` | ||
| option has no effect on the resulting service, since the actual class name | ||
| only depends on the object returned by the factory. However, the configured |
There was a problem hiding this comment.
I would split the first sentence:
When using a factory to create services, the value chosen for the
classoption has no effect on the result srvice. The actual name only depend on the object that is returned by the factory. [...]
There was a problem hiding this comment.
👍 Short sentences are always better. Fixed. Thanks!
|
Nice 👍 |
|
Agreed! It's basically tech-doc poetry :). Nice work Christian and Javier! |
…ed via factories (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added a note about the class option of the services defined via factories | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #4368 The original comment by @xabbuh in #4368 explained everything so well, that I decided to just copy it. Commits ------- 2551322 Rewording 90956cc Minor rewording 477da91 Minor rewording 27ca372 Added a note about the class option of the services defined via factories
The original comment by @xabbuh in #4368 explained everything so well, that I decided to just copy it.