Fixes for 2.3 branch #4943
Merged
Fixes for 2.3 branch #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ifdattic
commented
Jan 30, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3 |
| Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| 'tokens' => array( | ||
| 'a' => 'a6c1e0b6', | ||
| 'b' => 'f4a7b1f3', | ||
| ) |
There was a problem hiding this comment.
We could also use this:
$tokens = array('tokens' => array(
'a' => 'a6c1e0b6',
'b' => 'f4a7b1f3',
));What do you think?
There was a problem hiding this comment.
-1 for that proposal
+1 for the comma
I think the key is a bit lost in the proposal and it isn't very clear that it's a tree structure and a and b are childs of tokens.
There was a problem hiding this comment.
Yes sorry, missed that comma, will fix soon.
At first I also did as @xabbuh suggested, but decided against it as it doesn't make it as clear.
There was a problem hiding this comment.
Indeed, this is more readable than what I suggested.
wouterj
added a commit
that referenced
this pull request
Jan 31, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Fixes for 2.3 branch | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- e2769ba Update sessions.rst 4476646 Fix code example to be more readable cd1dfa4 Fix typo: These => This
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.