Skip to content

Fixes for 2.3 branch #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2015
Merged

Fixes for 2.3 branch #4916

merged 2 commits into from
Jan 30, 2015

Conversation

ifdattic
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets

@ifdattic
Fix typos
4d400bd 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
@ifdattic
Remove horizontal scrollbar
7065dd1 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
@ifdattic
Copy link
Contributor Author

On components/console/introduction.rst line 471 isn't it bad that original $input variable is replaced?

@wouterj
Copy link
Member

wouterj commented Jan 25, 2015

On components/console/introduction.rst line 471 isn't it bad that original $input variable is replaced?

I'm +1 for using another variable. ($innerInput?)

@ifdattic
Copy link
Contributor Author

In one of my projects I'm using $commandInput

@weaverryan
Copy link
Member

And +1 for changing the variable name!

@weaverryan weaverryan merged commit 7065dd1 into symfony:2.3 Jan 30, 2015
weaverryan added a commit that referenced this pull request Jan 30, 2015
@weaverryan
minor #4916 Fixes for 2.3 branch (ifdattic)
20d80c3 
This PR was merged into the 2.3 branch.

Discussion
----------

Fixes for 2.3 branch

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Commits
-------

7065dd1 Remove horizontal scrollbar
4d400bd Fix typos
@ifdattic ifdattic deleted the patch-20 branch January 30, 2015 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifdattic @wouterj @weaverryan