Monolog Cookbook Typo Fix: "allows to" should be "allows you to" #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattjanssen
commented
Jan 14, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | none |
Monolog allows [you] to...
| @@ -220,7 +220,7 @@ easily. Your formatter must implement | |||
| Adding some extra Data in the Log Messages | |||
| ------------------------------------------ | |||
|
|
|||
| Monolog allows to process the record before logging it to add some | |||
| Monolog allows you to process the record before logging it to add some | |||
There was a problem hiding this comment.
I'm not a native speaker, but I think this was correct before.
There was a problem hiding this comment.
Here's a quick discussion on the phrase "allows to":
There was a problem hiding this comment.
Another option would be "Monolog allows processing of the record before..."
|
Let's see what our native speaker @weaverryan thinks about this |
|
British or US English? |
|
@mattjanssen AE |
|
Both sound ok and so are probably correct. But this new change is correcter. Ahem, I mean more correct. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
…you to" (mattjanssen) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4837). Discussion ---------- Monolog Cookbook Typo Fix: "allows to" should be "allows you to" | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | none Commits ------- 2b73801 Typo Fix: "allows to" should be "allows you to"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.