Update routing.rst #4760
Merged
Update routing.rst #4760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ifdattic
commented
Jan 4, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3 |
| Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
|
I like it! 👍 |
| $this->get('router')->generate('blog', array('page' => 2, 'category' => 'Symfony')); | ||
| $this->get('router')->generate('blog', array( | ||
| 'page' => 2, | ||
| 'category' => 'Symfony' |
There was a problem hiding this comment.
A quick question: do we add a trailing comma for the last array element in the docs ... or do we only add it in code?
There was a problem hiding this comment.
Usually we follow this rule in the docs too.
There was a problem hiding this comment.
Crap, missed the comma, losing my sharpness I guess :D
Yea, usually docs have the trailing comma and as contribution docs has a section about having trailing comma, in my opinion it's a good idea to follow that rule in docs also.
wouterj
added a commit
that referenced
this pull request
Jan 8, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Update routing.rst | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- ddf0bc9 Update routing.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.