Set twig service as private #4697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the best practices workshop it was suggested that it's best to set services to private if they won't be accessed from your code/container
|
👍 but I let best practices co-author @weaverryan merge this |
|
👍 |
|
Great! Nice addition @ifdattic! |
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Set twig service as private During the best practices workshop it was suggested that it's best to set services to private if they won't be accessed from your code/container (for performance reasons) | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- 7427051 Set twig service as private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the best practices workshop it was suggested that it's best to set services to private if they won't be accessed from your code/container (for performance reasons)