Patch 1 #4688
Closed
Patch 1 #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (egeloen) This PR was merged into the master branch. Discussion ---------- [Form] Add entity manager instance support for em option This PR documents symfony/symfony#12251 Commits ------- 09a6fd7 [Form] Add entity manager instance support for em option
…yan, nicolas-grekas) This PR was merged into the master branch. Discussion ---------- [#4243] Tweaks to the new var-dumper component | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets | none Hi guys! This follows after #4243 - the best way to review it was to merge, read from scratch, and make these final tweaks. As always, I've certainly made some mistakes, so I appreciate the review. Thanks! Commits ------- 1a29f24 typos in the var-dumper component 265604b [#4243] Tweaks to the new var-dumper component
* 2.7: typos in the var-dumper component [#4243] Tweaks to the new var-dumper component [Form] Add entity manager instance support for em option [#4336] Backporting minor syntax fix Included a bunch of fixes suggested by the awesome Symfony doc reviewers Added a bunch of fixes suggested by @xabbuh Fixed a RST formatting issue Revamped the Quick Start tutorial tweaks to #4427 Updated first code-block:: bash
* 2.7: separate table columns with two spaces consistent table headlines
* 2.7: (22 commits) Fix up the final sentence to be a bit cleaner. SetDescription required on Product entities typo fix Fixed typo Modifying the best practice to use form_start() instead of <form Proposing that we make the service names *just* a little bit longer fix elseif statement Added a reference to the Bootstrap 3 form theme remove versionadded directives for old versions Fixed wrong indentation Bot fixes refer to the VarDumper component for dump() tweaks to the Twig reference Removed unnecessary use statement in code example in the debugging cookbook [Form] document $deep and $flatten of getErrors() describe how to access form errors Changed userName to username Update slash_in_parameter.rst Applied suggestion by Ryan Update form_customization.rst ...
* 2.7: Yet another typo fix Applied fixes Applied comments Typo fix Use new factory syntax link to a bundle's current (not master) docs Documented new tags Documented expressionlanguage extensibility Documented html5 option Renamed empty_value to placeholder
* 2.7: Fixing build error Big update based on feedback from xabbuh and WouterJ Moving forwarding section all the way to the bottom Completely re-reading the controller chapter
* 2.7: Removing bad period
* 2.7: Updating the installer docs to exactly match that repository's README - see #4533 Add command to make symfony.phar executable. fixed little typo
* 2.7: (45 commits) Front-porting changes by @pborreli in #4531 Fixed typos Update web_server_configuration.rst Update web_server_configuration.rst Added two missing pulls Added November changelog Added November changelog Added November changelog Updated documentation regarding the SecurityContext split; symfony/symfony#11690 Adding tiny note changing line breaks to be shorter, no real change [#4050] Backporting some additions to 2.3 added logging to translator. Missing attribute 'original' remove service class parameters Fixes concat operator typo Incorporates @wouterj 's suggestion for more realistic usage of bang Changes operator spacing language Adds missing space before return statement Fixes spelling and formatting errors ...
* 2.7: Use the new build env on Travis required PHPUnit version in the docs should be updated to 4.2 (or later) since the atLeast() method which is used in some of the tests Reverts a commit to 2.3 for 2.4 features. This re-adds them to the 2.5 branch Fixing bad merge Replace form_enctype(form) with form_start(form). Remove ExpressionLanguage reference for 2.3 version
* origin/master:
* 2.7: [#4625] Removing link added for BC, because this is the top of the page anyways Added '-ing' title ending to unify titles look [OptionsResolver] Fix namespace [OptionsResolver] Fix Namespace link filesystem headlines match method names Change refering block name from content to body Update pdo_session_storage.rst When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value. Fixing missing services key readd mistakenly removed label fix feature freeze dates
* 2.7: (35 commits) Update forms.rst link to the API documentation Re-wording parameters.yml section and removing note about vendor #4608 [#4608] Using #. for numbered bullets Changing and -> or based on conversation in #4532 Changed to definition lists from Book section Changed to definition lists Fixed heading capitalization to follow the standards Changed paragraph to heading Changed unordered list to definition list Spelling mistake tens to tons Removed double `firewall_restriction` entry Normalize the method listings on version 2.5 Update controllers.rst Update the_controller.rst replace Symfony2 with Symfony Linked the PDO/DBAL Session article from the Doctrine category Fix indentation of YAML example Fixed some code indentation Matching up the index position with the map ...
* 2.7: Replaced a "note" by a "seealso" Imrpoved the wording of the note about using using legacy PHP 5.3 version Reworded the reasons why you should use Composer-based installation Wrapped a line to follow doc standards Display the same version number on Linux and Windows to avoid confusions Add an explicit command to better explain that we recommend to move symfony.phar to projects directory Reworded a confusing phrase Added a note about verifying Symfony digital signatures Re-added a wrongly deleted link reference Rewritten from scratch the chapter about installing Symfony
* 2.7: Fix for symfony code standards Ref #3903 - Normalize methods listings drop varnish 2 example from varnish cookbook article Rewrite the varnish cookbook article Fixes and tweaks Change PHPUnit link to avoid redirect to homepage Harmonize PHPUnit version to 4.2 or above Remove redundant "default" connection. More tweaks and grammar fixes Rewordings and transformed a list into a definition list More grammar fixes Minor grammar fix Fixed some errors in the explanation Documented the console environment variables Changed the "new in Symfony 2.6" message for consistency Documented getProgress/setProgress methods update ordered list syntax Add missing autoload include in basic application example Added cache_busting to default asset config
* 2.7: Update map.rst.inc Coding standard for PHP block. Fix coding standards #2 Use alphabetical order. Fix duplicated references. Add some references. Reference available services Better match Symfony documentation standard. Github => GitHub Fix typo and add Github link. Deploy Symfony application on Platform.sh.
There are two code samples which are inconsistent which each other. I updated one of them.
|
Thank you @rodrigorigotti for submitting this PR! I've created a new PR with your commits without those other commits in #4689 I'll merge it as soon as travis passes. |
wouterj
added a commit
that referenced
this pull request
Dec 28, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4689). Discussion ---------- Update form_customization.rst This replaces a PR by @rodrigorigotti: #4688. Many thanks to him! Original PR description: > There are two code samples which are inconsistent which each other. I updated one of them. Commits ------- 4cd2046 Update form_customization.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.