Skip to content

Update page_creation.rst #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ownsourcing
Copy link

minor clarifying changes to the sentence

minor clarifying changes to the sentence
@@ -492,7 +492,7 @@ the same basic and recommended directory structure:
This directory contains the application configuration.

``src/``
All the project PHP code is stored under this directory.
All the project-specific PHP code and template files are stored under this directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the best practice section, we give the advice to store templates in the app directory instead of putting it in an application bundle.

@ownsourcing
Copy link
Author

@xabbuh --thanks for the additional information. I'm trying out Symphony, so the info you provide (and the corrections that should come from it) should be useful. I'll submit a new pull request showing the changes that arise for me from your point about best practices.

@ownsourcing ownsourcing reopened this Dec 27, 2014
@wouterj
Copy link
Member

wouterj commented Dec 27, 2014

@ownsourcing you can just add a new commit in this branch (click on the "edit" button when you're in the "files" tab of this PR). The PR will automatically be updated.

@ownsourcing
Copy link
Author

@wouterj, that approach to improving the pull request makes sense - thanks.

That said, I'm finding myself turning in circles within the documentation. I probably need more familiarity before I can reasonably reconcile the different takes on purpose of directories (there seem to be conflicting pieces of information in this doc itself).

I've submitted a notion that I think would help make the focus of this page more achievable. It may be worth considering with an open mind, or it may be that most readers can navigate the difficulties of the page.

For now I'll plow on with building familiarity (recognizing I'll soon no longer have the fresh view I currently have), then see what contributions are of use to the community and within my ability to share.

Kudos to the docs team!

@wouterj
Copy link
Member

wouterj commented Dec 27, 2014

@ownsourcing it might be possible that some docs are in conflict. Some weeks ago, Symfony published a "Best Practices Guide", which contained some completely new ideas on how to organize your app and do stuff. The docs are in the middle of a big update to comply with these new ideas.

@javiereguiluz
Copy link
Member

@ownsourcing thanks for sending this pull request and for helping us improve the documentation. However, as pointed by @wouterj, the recent Symfony Best Practices don't recommend to put the templates in src/ but in app/. Sadly this means that we should close this pull request without merging it. But don't worry, I'm sure next time your pull request will get merged. Thanks!

@wouterj wouterj closed this Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants