Skip to content

Update page_creation.rst #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ownsourcing
Copy link

confusion for newbies: _dev is the version with AcmeDemoBundle route as @AcmeDemoBundle/Resources/config/routing.yml (without dev, the only resource is @AppBundle/Controller/)

confusion for newbies: _dev is the version with AcmeDemoBundle route as @AcmeDemoBundle/Resources/config/routing.yml (without dev, the only resource is @AppBundle/Controller/)
@wouterj
Copy link
Member

wouterj commented Dec 27, 2014

Hmm, changing this to routing_dev is wrong, as is keeping the current sentence. The main routing file is in fact routing.yml in prod en routing_dev.yml in dev/test. However, saying this might fill this chapter with stuff that only keeps the reader away from the tutorial itself.

I think we should leave this sentence as it was, but then change the paragraph after this, as the comments in the code block and the paragraph seem to suggest this is the contents of the routing.yml file, while it is the routing_dev.yml file.

Can you please make such changes? Thanks for the PRs your already opened, I always like it to get feedback (and fixes) from people using the docs!

@xabbuh
Copy link
Member

xabbuh commented Mar 8, 2015

@ownsourcing Can you make the changes suggested by @wouterj?

@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. and removed actionable Clear and specific issues ready for anyone to take them. labels May 23, 2015
@javiereguiluz
Copy link
Member

This pull request can be closed because the underlying page (book/page_creation.rst) has recently been rewritten from scratch. @ownsourcing I think you'll find the new page written by @weaverryan much better and easier to follow than the original one. I certainly do!

@weaverryan
Copy link
Member

@javiereguiluz is right! The document should be much better now in general. If you find anything misleading or confusing, please let us know!

Thanks!

@weaverryan weaverryan closed this Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants