Skip to content

Documented the console environment variables #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 22, 2014

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #4162

$ php app/console command_name

# 'prod' environment and debug enabled
$ php app/console command_name --env=prod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. The console file has a special handling for the prod env, forcing it to be in no-debug mode: https://github.com/symfony/symfony-standard/blob/20516f547e3282a1b3aeec2a284efd311aa9f5a4/app/console#L19
Use --env=test instead for this case

any command:

* ``SYMFONY_ENV``, sets the execution environment of the command to the value of
this variable (``dev``, ``prod``, ``test``, etc.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should end with a semi-colon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

By default, Symfony commands are executed in the ``dev`` environment and with the
debug mode enabled. Use ``--env`` and ``-no-debug`` options to modify this behavior:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the [...]

* ``SYMFONY_ENV``, sets the execution environment of the command to the value of
this variable (``dev``, ``prod``, ``test``, etc.);
* ``SYMFONY_DEBUG``, if ``0``, debug mode is disabled. Otherwise, debug mode is
enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a definition list here?

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

@javiereguiluz Wow, thanks for your really fast reaction. 👍

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

By default, Symfony commands are executed in the ``dev`` environment and with the
debug mode enabled. Use the ``--env`` and ``-no-debug`` options to modify this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one dash missing in front of no-debug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch! Thanks.

@javiereguiluz
Copy link
Member Author

@xelaris @xabbuh thanks for your review! Everything is fixed now.

@weaverryan
Copy link
Member

This is awesome - great work Javier!

@weaverryan weaverryan merged commit df2a0f2 into symfony:2.3 Dec 22, 2014
weaverryan added a commit that referenced this pull request Dec 22, 2014
…iluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Documented the console environment variables

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #4162

Commits
-------

df2a0f2 Fixes and tweaks
dd8157f More tweaks and grammar fixes
2fb082d Rewordings and transformed a list into a definition list
a1d88d8 More grammar fixes
8ead4a4 Minor grammar fix
6fc8f4c Fixed some errors in the explanation
7c4cd17 Documented the console environment variables
@javiereguiluz javiereguiluz deleted the fix_4162 branch February 18, 2015 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants