[Hackday] Update Heroku doc with SYMFONY_ENV param #4545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxnr
commented
Nov 29, 2014
| Q | A |
|---|---|
| Doc fix? | [yes] |
| New docs? | [no] |
| Applies to | [2.5, 2.6, 2.7] |
| Fixed tickets | #4217 |
|
This resolves #4217, right? |
|
It looks like that, thanks @xabbuh! I update description. |
| .. code-block:: yaml | ||
|
|
||
| "post-install-cmd": [ | ||
| "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", |
There was a problem hiding this comment.
is it really a good idea to show the complete content of the composer.json here?
this will become bad if we have to maintain this for different versions. i would prefer something like:
make sure you removed: ....
make sure you added: ....
There was a problem hiding this comment.
I would indeed prefer to use ... to fold some irrelevant things.
There was a problem hiding this comment.
This is no longer necessary, the underlying issue is now fixed in Symfony.
There was a problem hiding this comment.
this section should then be removed from this PR to avoid confusion
|
Just realized my #4591 is a duplicate of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.