Skip to content

Update link to remove absolute URL #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 1, 2014
Merged

Update link to remove absolute URL #4537

merged 7 commits into from
Dec 1, 2014

Conversation

jms85
Copy link
Contributor

@jms85 jms85 commented Nov 29, 2014

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

Thank you both @jms85 and @dangarzon.

By the way, you don't necessarily have to create a pull request per best practices document. It's okay if you put all changes in one large pull request.

@wouterj
Copy link
Member

wouterj commented Nov 29, 2014

I'll leave this one open, you can push all changes in this PR.

@jms85
Copy link
Contributor Author

jms85 commented Nov 29, 2014

@wouterj
We have removed not used urls in best practices document and changed those in use to relative urls

@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

@jms85 @dangarzon Thank you, this looks good.

@wouterj
Copy link
Member

wouterj commented Nov 29, 2014

Hmm, let's wait on travis for this PR to be sure we don't introduce errors (a typo is made quickly :P).

@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

Yes, there's no need to hurry here.

@dangarzon
Copy link
Contributor

@xabbuh @wouterj
Travis liked it :D

@wouterj wouterj merged commit 7282965 into symfony:2.3 Dec 1, 2014
wouterj added a commit that referenced this pull request Dec 1, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Update link to remove absolute URL

Commits
-------

7282965 Change symfony-docs internal links avoiding absolute urls in introduction article
ffa17b2 Change symfony-docs internal links avoiding absolute urls in security article
c7f9cf5 Remove unused links
079bd64 Change symfony-docs internal links avoiding absolute urls
cf32b4c Remove absolutes url
ae877f2 Remove absolute url from override_dir_structure link
f7de50e Update link to remove absolute URL
@wouterj
Copy link
Member

wouterj commented Dec 1, 2014

Thank you @dangarzon and @jms85 for your great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants