[BestPractices] Proposing that we make the service names *just* a little bit longer #4463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion this seems very reasonable. |
|
👍 It does not only make it easier to find your own services with |
|
looks good to me And btw, this means that the best practice would be the same than for shared bundles (given your bundle is named AppBundle and so its alias is |
|
👍 |
|
I'm -0.3 on this, but I won't stop this PR from merging. |
|
Great - thanks for the feedback - especially Wouter - I like your -0.3, much more precise that the full +/-1 :). |
weaverryan
added a commit
that referenced
this pull request
Nov 20, 2014
…s *just* a little bit longer (weaverryan) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4463). Discussion ---------- [BestPractices] Proposing that we make the service names *just* a little bit longer | Q | A | --- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Hi guys! This is a very minor proposed change for the best practices, which I would like to consider. The original best practice was because we don't want people to blindly follow the 3rd party service naming that's quite long. In your own app, they just need to be unique within yourself. But personally, I *do* use things like `app.slugger`, because I like to be able to grep my codebase for a service and reliably find it. Thanks! Commits ------- b1ceb88 Proposing that we make the service names *just* a little bit longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is a very minor proposed change for the best practices, which I would like to consider. The original best practice was because we don't want people to blindly follow the 3rd party service naming that's quite long. In your own app, they just need to be unique within yourself. But personally, I do use things like
app.slugger, because I like to be able to grep my codebase for a service and reliably find it.Thanks!