[Reference] Fixed lots of minor things using the review bot #4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <doctrine:datetime-function name="test_datetime">Acme\HelloBundle\DQL\DatetimeFunction</doctrine:datetime-function> | ||
| <doctrine:string-function | ||
| name="test_string" | ||
| >Acme\HelloBundle\DQL\StringFunction</doctrine:string-function> |
There was a problem hiding this comment.
This looks strange compared to the functions below.
There was a problem hiding this comment.
yes, will fix that. I first thought there was no trim transformation done on this value, it turns out there is.
|
Cool! I like what the review bot is catching already. Let me know how its progress goes :). |
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2014
…ot (WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- [Reference] Fixed lots of minor things using the review bot I started working on our review bot. While doing that, I was using some documents that didn't change a lot. I decided it was usefull to have these things fixed in the docs itself :) All are very minor, basic, review things. | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 9befcaf Fixed wrong indentation a2c626f Bot fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on our review bot. While doing that, I was using some documents that didn't change a lot. I decided it was usefull to have these things fixed in the docs itself :) All are very minor, basic, review things.