Skip to content

Fixed make file #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2014
Merged

Fixed make file #4453

merged 1 commit into from
Nov 18, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 12, 2014

For some reason, the make.bat file contained the same contents as MakeFile, while it should contain the bash code port of the MakeFile. This PR fixes that

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2014

Is it somehow possible to test this on Travis CI?

@wouterj
Copy link
Member Author

wouterj commented Nov 12, 2014

I don't see a reason why.

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2014

I first thought that it would be good to ensure that the docs built successfully on Windows. But we obviously don't change this file usually. So it doesn't make much sense.

@wouterj wouterj merged commit f38bbef into symfony:2.3 Nov 18, 2014
wouterj added a commit that referenced this pull request Nov 18, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fixed make file

For some reason, the `make.bat` file contained the same contents as `MakeFile`, while it should contain the bash code port of the MakeFile. This PR fixes that

Commits
-------

f38bbef Fixed make file
@wouterj wouterj deleted the fix_make branch November 18, 2014 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants