Skip to content

Updated first code-block:: bash #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated first code-block:: bash #4441

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2014

The command for executing an console command was wrong. The php command was missing. It will help further readers.

The command for executing an console command was wrong. The php command was missing. It will help further readers.
@javiereguiluz
Copy link
Member

👍 thanks for fixing this error!

@xabbuh
Copy link
Member

xabbuh commented Nov 11, 2014

👍 Thanks for the fix @nitaco!

@weaverryan @wouterj This has to be applied to the 2.3 branch.

@ghost
Copy link
Author

ghost commented Nov 11, 2014

no problem, guys :)

wouterj added a commit that referenced this pull request Nov 11, 2014
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4441).

Discussion
----------

Updated first code-block:: bash

The command for executing an console command was wrong. The php command was missing. It will help further readers.

Commits
-------

9f7fda4 Updated first code-block:: bash
@wouterj
Copy link
Member

wouterj commented Nov 11, 2014

Thanks Lukas!

For your information, this command does work when running it on a unix PC, as it supports hash-bangs. Windows doesn't support that, so it indeed requires the php executable/binary first. This will do no harm for unix PCs, so this change is 100% correct!

@wouterj wouterj closed this Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants