Fixed variable naming #3775
Closed
Fixed variable naming #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, good fix! This is not consistent with the other helpers. Cheers Peter! |
weaverryan
added a commit
that referenced
this pull request
Apr 12, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3775). Discussion ---------- Fixed variable naming Changed $app into $this since this is used in the other helpers as well and $app is not available inside a console command. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 66581a6 Fixed variable naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed $app into $this since this is used in the other helpers as well and $app is not available inside a console command.