make method supportsClass() in custom voter compatible with the interface's documentation #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Mar 21, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #3702 |
|
👍 |
| { | ||
| return $obj instanceof Post; | ||
| return 'Acme\DemoBundle\Entity\Post' === $class; |
There was a problem hiding this comment.
Possibly change that to the following to be more like instanceof?
$supportedClass = 'Acme\DemoBundle\Entity\Post';
return $supportedClass === $class || is_subclass_of($class, $supportedClass);…face's documentation
|
I should have known the #3702 issue would already have a fix ;). Thanks Christian! |
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2014
… the interface's documentation (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- make method supportsClass() in custom voter compatible with the interface's documentation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #3702 Commits ------- 36384db make method supportsClass() in custom voter compatible with the interface's documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.