Skip to content

Conversation

@alvarezmario
Copy link
Contributor

I'm not a native speaker but I think that it reads better now.

I'm not a native speaker but I think that it sounds better by adding that before the word `start`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our standard is to avoid the first person perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of you, we should avoid the first person, but the current sentence really needs a first person perspective here. So we have to rewrite the complete sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, I'm also struggling a bit here :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the best way to learn is to see an example, just imagine that you want to secure your application with HTTP Basic authentication.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that's really great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @Nomack84 - do you want to make the change suggested by @xabbuh?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan I'll close this PR because I did it with the edit featured of GitHub and I'll create a new one with this change by @xabbuh

@alvarezmario
Copy link
Contributor Author

Well, I think that's not necessary so I'll do it in this one in a moment.

@alvarezmario
Copy link
Contributor Author

@weaverryan It's done.

@weaverryan
Copy link
Member

Great, thanks Mario!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants