Skip to content

Conversation

@wouterj
Copy link
Member

@wouterj wouterj commented Feb 18, 2014

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #955

Fixed the remeaning tasks of #955 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the comma.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it both ways on the net when I search for "Sometimes, you need to" - so I'm cool either way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? Well, you are the native. If you don't object, then let's stick with this. :)

@weaverryan
Copy link
Member

👍 just one small tweak!

@wouterj
Copy link
Member Author

wouterj commented Mar 8, 2014

@weaverryan fixed :)

@weaverryan
Copy link
Member

Awesome, you rock Wouter!

weaverryan added a commit that referenced this pull request Mar 9, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Finishing the Templating component docs

| Q   | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | all
| Fixed tickets | #955

Fixed the remeaning tasks of #955 (comment)

Commits
-------

b215395 Applied comment from @weaverryan
9f34675 Documented custom engines and DelegatingEngine
e243485 Added a note on caching
3a9f140 Added globals section
@weaverryan weaverryan merged commit b215395 into symfony:2.3 Mar 9, 2014
@wouterj wouterj deleted the components-enhancing_templating branch March 9, 2014 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants