Skip to content

Fix highlighting #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2014
Merged

Fix highlighting #3497

merged 2 commits into from
Jan 22, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jan 21, 2014

Initial idea was to fix the highlighting. While doing that, others things
also got a fix:

  • indenting
  • missing formats
  • some ... in XML elements
  • missing comments in other formats
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets partially #1886

Initial idea was to fix the highlighting. While doing that, others things
also got a fix:

* indenting
* missing formats
* some `...` in XML elements
* missing comments in other formats
@xabbuh
Copy link
Member

xabbuh commented Jan 21, 2014

👍

weaverryan added a commit that referenced this pull request Jan 22, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fix highlighting

Initial idea was to fix the highlighting. While doing that, others things
also got a fix:

* indenting
* missing formats
* some `...` in XML elements
* missing comments in other formats

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | partially #1886

Commits
-------

7c0cf89 Fixed (mostly) yaml code blocks
2a43a97 Fixed YAML code blocks in the book
@weaverryan weaverryan merged commit 7c0cf89 into symfony:2.3 Jan 22, 2014
@weaverryan
Copy link
Member

Wow @wouterj - this is a huge PR with so many fixes, consistencies items, etc. Great work with this! Easy merge despite being so large!

@wouterj wouterj deleted the fix_highlighting branch January 22, 2014 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants