[Reference][Form Types] Add missing docs for "action" and "method" option #3436
Conversation
| * PATCH | ||
|
|
||
| As PUT, DELETE and PATCH are not nativly supported by most clients, Symfony | ||
| simulates them, see :doc:`/cookbook/routing/method_parameters`. |
There was a problem hiding this comment.
for more information see ... || to read more see ...
|
PATCH also has a special property in that if any fields are missing from the submit, those won't be removed: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php#L80 That uses the 2nd argument of the @bicpi Can you add a quick note about the PATCH behavior? Then, if you're ready, I'd like to merge this! Cheers! |
|
And this needs a rebase btw |
|
Rebase done, will work on the missing update soon. |
|
@weaverryan Added a note about the PATCH method, hope that it's well drafted. |
|
Thanks Philipp - very well done indeed - the slow merge was because of me :). Cheers! |
…nd "method" option (bicpi) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Add missing docs for "action" and "method" option | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 I'm not sure of adding these two options as separate rst-files because I don't think they will get listed as `inherited` options. But no other options are embedded directly. Please let me know if I can improve that. Commits ------- 793c8a0 Add note about the PATCH method 4555495 Update note wording for "method" option 70ca6da Improvements after review cecc762 Update "method" description a636945 Fixes after review 83ff4b1 Improve descriptions 1bf3ce0 [Reference][Form Types] Add missing docs for "action" and "method" option
This PR was merged into the 2.3 branch. Discussion ---------- Minor tweaks to form action/method This adds a little bit more to #3436. The toughest part is the wording around explaining the PATCH behavior - suggestions warmly welcomed :). | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | none Thanks! Commits ------- 34f5b0c Some slight reordering of the form options - and also tweaking language around PATCH behavior
I'm not sure of adding these two options as separate rst-files because I don't think they will get listed as
inheritedoptions. But no other options are embedded directly. Please let me know if I can improve that.