[Reference][Form Types] Add "max_length" option in form type #3432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nykopol
commented
Jan 6, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | #3410 (task Form -> max_length) |
|
👍 |
| If this option is not null, an attribute ``maxlength`` is added, which | ||
| is used by some browsers to limit the amount of text in a field. | ||
|
|
||
| This is just a browser validation, so datas still must be validated |
There was a problem hiding this comment.
client-side -- .. so data must still be ...
There was a problem hiding this comment.
thanks @bicpi It's fixed.
| If this option is not null, an attribute ``maxlength`` is added, which | ||
| is used by some browsers to limit the amount of text in a field. | ||
|
|
||
| This is just a browser validation, so datas must still be validated |
There was a problem hiding this comment.
Fixed the last one !?
|
Awesome work @nykopol. Keep it up - and thanks! |
weaverryan
added a commit
that referenced
this pull request
Jan 9, 2014
…e (nykopol) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Add "max_length" option in form type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task Form -> max_length) Commits ------- b53a227 fix last typo on max length option d6800d3 fix typo in previous commit 391fe30 fix typo in previous commit 2156545 add max_length to form field type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.