Skip to content

[Session Configuration] add clarifying notes on session save handler proxies #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cordoval
Copy link
Contributor

@cordoval cordoval commented Jan 4, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #2889
License CC-ASA 3.0 Unported

Sent using Gush

docblock of the ``setOptions()`` method of each class.
the docblock of the ``setOptions()`` method of each class. For an example of this for
a save handler provided via the Memcached extension is
`php.net/manual/en/memcached.setoption`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of a save handler provided via the Memcached extension can be found on `php.net`_

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal was wrong, I suggest:

For instance, the one provided by the Memcached extension can be found on `php.net/memcached.setoption`_

@cordoval
Copy link
Contributor Author

cordoval commented Jan 5, 2014

:shipit:

@@ -234,6 +235,11 @@ PHP 5.4 functionality if it is available.
Save Handler Proxy
~~~~~~~~~~~~~~~~~~

A Save Handler Proxy is basically a wrapper around a Save Handler that was
introduced to support seamlessly the migration from PHP 5.3 to PHP 5.4+. It
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to seamlessly support

@weaverryan
Copy link
Member

Cool 👍 Thanks Luis!

weaverryan added a commit that referenced this pull request Jan 9, 2014
…e handler proxies (cordoval)

This PR was merged into the 2.3 branch.

Discussion
----------

[Session Configuration] add clarifying notes on session save handler proxies

| Q             | A                   |
| ---           | ---                 |
| Doc fix?      | yes                 |
| New docs?     | no                  |
| Applies to    | 2.3+                |
| Fixed tickets | #2889               |
| License       | CC-ASA 3.0 Unported |

 Sent using [Gush](https://github.com/cordoval/gush)

Commits
-------

771b862 address comments from @wouterj
2888d00 answer some questions and clarify the best chapter imo from the symfony documentation
@weaverryan weaverryan merged commit 771b862 into symfony:2.3 Jan 9, 2014
@cordoval cordoval deleted the 2889-explain-what-a-session-save-handler-proxy-is branch January 9, 2014 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants