[Cookbook][Configuration] add configuration cookbook handlig parameters in Configurator class #3420
Conversation
|
Wow, you are also heavily contributing to the docs? 😉 FYI, the License row is not needed in the doc PR format. |
| @@ -89,6 +89,8 @@ The second method has several specific advantages: | |||
| supported configuration settings for which backward compatibility will | |||
| be maintained. | |||
|
|
|||
| For other usages of the parameter ``%`` syntax see :doc:`Configuration </cookbook/configuration>`. | |||
There was a problem hiding this comment.
put the hole :doc: role on a new line
There was a problem hiding this comment.
and this should be placed in a .. seealso:: directive
|
@cordoval, what do you mean? You can use it at any time to resolve the string into a parameter value, if the syntax is correct. |
| ``%kernel.debug%`` debug mode parameter to make your bundle adapt its | ||
| configuration depending on this. For this case you cannot use | ||
| the syntax directly and expect this to work. The configuration handling | ||
| will just tread this ``%kernel.debug%`` as a string. Consider |
|
@wouterj about the |
| @@ -6,6 +6,7 @@ Configuration | |||
|
|
|||
| environments | |||
| override_dir_structure | |||
| using_configuration_parameters | |||
There was a problem hiding this comment.
I think we're missing the addition in cookbook/map.rst.inc
|
Hey Luis! I think you did some nice writing on this entry, thanks for starting it! But, I want to make it much smaller. Imo, this entry is too large for the small question that it's answering. After reading it, I don't think we should talk about how parameters are used or what they are at all. The point of this article, and what I think we should rename it to, is "How to use Parameters (e.g. kernel.debug) within a DependencyInjection Extension Class". Then, I think we should show them the answer directly. This comment comes after my line-comments above - I don't think we need to worry about those anymore because I think these sections should be removed. What do you think? |
|
@weaverryan agree, working on this right now |
|
@weaverryan 🚢 🇮🇹 boss |
| .. seealso:: | ||
|
|
||
| For other usages of the parameter ``%`` syntax see | ||
| :doc:`Using Parameters Within A Dependency Injection Class </cookbook/using_parameters_in_dic>`. |
There was a problem hiding this comment.
You don't have to use the title here:
:doc:`</cookbook/using_parameters_in_dic>`.There was a problem hiding this comment.
Additionally, the document is located at ``/cookbook/configuration/using_parameters_in_dic`.
| .. seealso:: | ||
|
|
||
| For other usages of the parameter ``%`` syntax see | ||
| :doc:`</cookbook/configuration/using_parameters_in_dic>`. |
|
bump 👶 |
|
bump @weaverryan @wouterj |
|
there is not much to bump me for.. I've reviewed it. Now, you only need to be patient. Believe me, you're PR isn't lost, ryan just didn't had the time to review it (with such big changes, it'll take longer to review and thus longer to merge) |
|
Yep, I'll review this shortly - I need to merge in some smaller PR's first :) |
|
I like it! A small, but complex topic with a nice explanation. Great work! |
…ndlig parameters in Configurator class (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Configuration] add configuration cookbook handlig parameters in Configurator class | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #3219 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 9710bb5 final touches ad27a83 address comments by xabbuh a6bda5e address weaverryan comments 28c144a plug xml and php version of the configuration c07c655 fix see also block ec13feb plug changes according to comments 243c0d1 create configuration cookbook with ways of handling paramters in Configurator class
Sent using Gush