Changed sha1 into bcrypt continued... #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… details in intro area that aren't necessary (you'll need to read the cookbook entry for more details anyways)
Also removing one example (now possible with using bcrypt from the beginning) and related tweaks.
Also filling in other details related to using BCrypt
|
|
||
| { | ||
| "require": { | ||
| "...": "all the other dependencies...", |
There was a problem hiding this comment.
Just ... to be consistent woth the other json examples
|
👍 @ircmaxell as you started this (and because you are the security expert), I would appreciate if you could have a look if this is heading in the good direction. |
| "...": "all the other dependencies...", | ||
| "ircmaxell/password-compat": "~1.0.3" | ||
| } | ||
| } |
weaverryan
added a commit
that referenced
this pull request
Jan 21, 2014
Changed sha1 into bcrypt continued...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows @wouterj's start in #3356. It uses BCrypt in even more places and reorganizes some sections. Hopefully this puts us in a good place. Comments warmly appreciated!
Thanks!