[Testing] Fix phpunit test dir paths #3343
Conversation
|
Hey Philipp! Yea, I'm glad you've caught this. What's happening is that this text is from a VERY old, pre 2.0 version of Symfony I believe - back when the best-practice for bundles was different, and I think we even had vendor bundles stored in Thanks! |
|
@weaverryan Sorry, closed by mistake...and re-opened ;-) I've done some tweaks to the section, replacing the notice about how to execute vendor tests (why testing vendor code from within a custom project? It would also need to install the composer deps for the vendor libs) by a notice how to add a non-standard (but custom) test directory. |
| @@ -686,7 +686,7 @@ their type:: | |||
| Testing Configuration | |||
| --------------------- | |||
|
|
|||
| The Client used by functional tests creates a Kernel that runs in a special | |||
| The client used by functional tests creates a Kernel that runs in a special | |||
There was a problem hiding this comment.
Client, it refers to an object, just like Kernel
|
Btw, many thanks @wouterj for all of your reviews! |
|
@weaverryan Anything I can still do for this PR? It's just because I stumbled over it again recently ;-) |
|
Nope - it looks great, thanks for the poke :). |
This PR was merged into the 2.3 branch. Discussion ---------- [Testing] Fix phpunit test dir paths | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Maybe there could be further improvements: The paragraph that follows is a bit confusing. It says *...the following configuration adds the tests from the installed third-party bundles* and then the tests from AcmeDemoBundle are included with `<directory>../src/Acme/Bundle/*Bundle/Tests</directory>`. Mh, the AcmeDemoBundle is a 3rd party bundle that resides in `src`? Shouldn't it include a directory from `vendors` instead to demonstrate this? In addition, the AcmeDemoBundle tests are covered by the standard configuration, so there should be no need for an extra configuration. It continues with *To include other directories in the code coverage..* and then some dirs from the AcmeDemoBundle are excluded which is also covered by the standard configuration. What do you think, should I make some more updates here? Commits ------- 75bd1e5 Fixes after review d17a20f Further tweaks to the PHPUnit configuration description 61cdfcc [Testing] Fix phpunit test dir paths
Maybe there could be further improvements: The paragraph that follows is a bit confusing. It says ...the following configuration adds the tests from the installed third-party bundles and then the tests from AcmeDemoBundle are included with
<directory>../src/Acme/Bundle/*Bundle/Tests</directory>. Mh, the AcmeDemoBundle is a 3rd party bundle that resides insrc? Shouldn't it include a directory fromvendorsinstead to demonstrate this? In addition, the AcmeDemoBundle tests are covered by the standard configuration, so there should be no need for an extra configuration.It continues with To include other directories in the code coverage.. and then some dirs from the AcmeDemoBundle are excluded which is also covered by the standard configuration.
What do you think, should I make some more updates here?