Skip to content

Added Iban constraint documentation #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2013
Merged

Added Iban constraint documentation #2521

merged 1 commit into from
May 3, 2013

Conversation

sprain
Copy link
Contributor

@sprain sprain commented Apr 20, 2013

Q A
Doc fix? no
New docs? yes (symfony/symfony#6677)
Applies to master
Fixed tickets #6677

Documented the newly merged feature of IBAN validator.
The feature has been merged to Symfony2 in Pull Request #6677

@@ -0,0 +1,88 @@
Iban
======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the heading line should be as long as the heading name

@wouterj
Copy link
Member

wouterj commented Apr 20, 2013

The ISBN validator docs is missing as well. I saw you also did some things on that one, have you planned to document it? (otherwise, I'll create an issue saying it should get documented)

Constraint has been merged to Symfony2 in Pull Request 6677
@sprain
Copy link
Contributor Author

sprain commented Apr 20, 2013

I think you should create the issue about the ISBN validator. I might document it if I find the time. However it's not my validator and I am not completely sure if I think its integration has been done well enough. I might have a look at it again.

weaverryan added a commit that referenced this pull request May 3, 2013
Added Iban constraint documentation
@weaverryan weaverryan merged commit a848e7b into symfony:master May 3, 2013
weaverryan added a commit that referenced this pull request May 3, 2013
@weaverryan
Copy link
Member

Great work Manuel!

77web pushed a commit to 77web/symfony-docs that referenced this pull request Nov 23, 2013
Based on feedback from @wouterj on the Iban validator doc.
See symfony#2521
77web pushed a commit to 77web/symfony-docs that referenced this pull request Nov 23, 2013
Based on feedback from @wouterj on the Iban validator doc.
See symfony#2521
@sprain sprain deleted the IbanConstraint branch March 27, 2014 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants