-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
added information about how deprecations work #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fabpot
commented
Feb 18, 2013
Q | A |
---|---|
Doc fix? | no |
New docs? | yes |
Applies to | all |
Fixed tickets | n/a |
deprecated, the version when it will be removed, and whenever possible, how | ||
the feature was replaced. | ||
|
||
A PHP error must also be triggered to help people with the migration one or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC "depending" and "must" are contradictory
maybe "[...] starting one or two[...]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A PHP E_USER_DEPRECATED error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
git add ? |
Deprecations | ||
------------ | ||
|
||
From time to time, some classes and/or methods are deprecated in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And think this should also be replaced with classes, methods, properties, constants, ect.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, as you deprecate a feature that is implemented in classes/methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why ie constants or interfaces would not be valid cases here also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because a feature cannot be made of constants only. You are nitpicking here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are times when we only deprecate a constant / option (ie form).
I think interfaces are at least non disputable.
I think it is good to mention the |