Skip to content

Add a cookbook entry to explain how to clear the cache before tests #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2012

Conversation

adrienbrault
Copy link
Contributor

Hi,

Following @fabpot's suggestion on symfony/symfony-standard#421

Add the following file::

// app/tests.bootstrap.php

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove this line, there shouldn't be an empty line between the file comment and the code

@adrienbrault
Copy link
Contributor Author

@wouterj Thanks for the review, updated

@bamarni
Copy link
Contributor

bamarni commented Sep 21, 2012

IMO a dedicated cookbook entry isn't appropriate for this, it would make more sense as a small note in the testing section, because this tutorial isn't so much related to symfony.

Out of curiosity, what issue can occur if one doesn't clear its cache between tests? As in the SE the test environment extends the dev environment, wich usually auto-regenerates some cache files when it's needed.

Edit: nevermind, it's explained in the first section of your change ;)

weaverryan added a commit that referenced this pull request Oct 3, 2012
Add a cookbook entry to explain how to clear the cache before tests
@weaverryan weaverryan merged commit 2dd4986 into symfony:2.0 Oct 3, 2012
weaverryan added a commit that referenced this pull request Oct 3, 2012
This was made a little bit more generic - and also includes some minor items
weaverryan added a commit that referenced this pull request Oct 3, 2012
@weaverryan
Copy link
Member

Hi Adrien!

I've merged this in with a few tweaks, including making the entry sound a little bit more generic (i.e. about customizing the bootstrap process of a test).

@bamarni I agreed with you initially about not having this in its own cookbook entry, but I think it's ok because (a) it's not a critical, core feature to testing and (b) it's much more "findable" (via google) as a standalone article. I think this type of separation can be a good thing - keeping the core articles smaller with more interlinking.

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants