Minor improvement: Cleaned up the WsseListener example #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($request->headers->has('x-wsse')) { | ||
| if (!$request->headers->has('x-wsse')) { | ||
| throw new BadCredentialsException('Missing mandatory WSSE header'); | ||
| } |
There was a problem hiding this comment.
This is wrong. It makes this listener impossible to use with others authentication listeners as the exception will prevent them from running. If you cannot authenticate the user for this request, you should simply do nothing.
There was a problem hiding this comment.
Ok, thank you for the tip. A 'return' should do the trick?
Good to know, I have to update the Listener in our code base.
Refactoring the WsseListener * AuthenticationManagerInterface will never return a Response, instanceof check is obsolete * Added option to redirect to the login page by clear the token of the securityContext
| $returnValue = $this->authenticationManager->authenticate($token); | ||
| $this->securityContext->setToken($authToken); | ||
| } catch (AuthenticationException $failed) { | ||
| // you might log something here |
There was a problem hiding this comment.
This should be
// ... you might log something here
weaverryan
added a commit
that referenced
this pull request
Sep 14, 2012
…provider Minor improvement: Cleaned up the WsseListener example
weaverryan
added a commit
that referenced
this pull request
Sep 14, 2012
|
Hi Dominic! These are really great changes! I've merged them in with basically no changes :) Thanks for the great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the WsseListener