Use ContainerAwareTrait

The AppBundle\Menu\Builder class extends Symfony\Component\DependencyInjection\ContainerAware that is deprecated since version 2.8, to be removed in 3.0. Use the ContainerAwareTrait instead.

Code from documentation:
http://symfony.com/doc/master/bundles/KnpMenuBundle/index.html#method-a-the-easy-way-yay

Maybe there are more code examples which should use ContainerAwareTrait.

rel KnpLabs/KnpMenuBundle#290

[xabbuh]

@JHGitty Did you find an example in the docs that is not related to the KnpMenuBundle or should we close here in favour of the issue you linked?

@xabbuh https://github.com/symfony/symfony-docs/search?utf8=%E2%9C%93&q=ContainerAware

[wouterj]

Both cases should be changed to extend Symfony\Bundle\FrameworkBundle\Controller\Controller instead. Can you make that change @JHGitty? (as you should get the credits!)

Anybody can do it :-) I have not much time for it.

[stof]

@wouterj no, they should not extend Controller. They are not controllers. They should use the trait

[wouterj]

@stof unless I'm missing something, both search results are controllers.

@stof WouterJ is talking about these lines:
https://github.com/symfony/symfony-docs/search?utf8=%E2%9C%93&q=ContainerAware

Both are controllers: FriendMessageController and MainController.

[stof]

ah sorry, indeed