Skip to content

[2.6] Add documentation for new controller helpers #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkisselev opened this issue Dec 17, 2014 · 3 comments
Closed

[2.6] Add documentation for new controller helpers #4666

dkisselev opened this issue Dec 17, 2014 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue.
Milestone
2.6

Comments

@dkisselev
Copy link

2.6 comes with those new redirect shortcut helpers:

http://symfony.com/blog/new-in-symfony-2-6-new-shortcut-methods-for-controllers

But it doesn't look like the docs have been updated to show them yet:

http://symfony.com/doc/current/book/controller.html#redirecting
@xabbuh xabbuh added Missing Documentation hasPR A Pull Request has already been submitted for this issue. labels Dec 17, 2014
@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

Hi @dkisselev, you're right that the book currently misses documentation for this feature, but luckily @Cydonia7 already opened a pull request for this: #4109

@xabbuh xabbuh added this to the 2.6 milestone Dec 17, 2014
@dkisselev
Copy link
Author

Sweet, thanks, I took a look through the issues and didn't see it but forgot to check PR's.

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

@dkisselev Never mind. :) We can just keep this open until the pull request gets merged in case others do the same search.

@Cydonia7 Cydonia7 mentioned this issue Dec 18, 2014
Closed
@wouterj wouterj mentioned this issue Feb 26, 2015
Merged
weaverryan added a commit that referenced this issue Mar 14, 2015
@weaverryan
feature #5046 Rebased "add shortcut methods" (Cydonia7, WouterJ)
3405c42 
This PR was merged into the 2.6 branch.

Discussion
----------

Rebased "add shortcut methods"

Replaces #4109

Original Pr description:

 > | Q             | A
 > | ------------- | ---
 > | Doc fix?      | no
 > | New docs?     | yes (symfony/symfony#11593)
 > | Applies to    | 2.6+
 > | Fixed tickets | #4666
 >
 > This commit is associated to symfony/symfony#11593 that adds new shortcut methods to controllers.
 >
 > If anything is wrong with my commit or this description, please tell me and I will fix it as soon as possible. I'm glad I finally try to help this awesome project.

Commits
-------

994ed3a Little fixes
f807d14 Fixes
5b015f2 Modifications according to comments
7f9bc8c And now the same for isGranted where it is possible
46e2505 Changed to addFlash where it is possible (ie in controllers)
643c458 redirect changed to redirectToRoute
7ae62e8 Minor improvements
4611ce9 Minor format improvements
3bcb186 Added shortcut methods for controllers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@weaverryan @dkisselev @xabbuh