-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Using Command Options describes missing feature #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It is indeed a documentation bug: the doc does not documents the actual behavior (which cannot change as lots of code is relying on it). Actually, the sentence here is not wrong. But it does not explain enough what the behavior is. |
As I understand it, we cannot "meaningfully distinguish between the two" as @EdwardIII said, and that won't be fixable in the code. So, you can either have So what should we add/change? Is it that we're not really showing what value will be returned in each case? |
Ping, what is missing? |
@wouterj Someone needs to create a pull request. :) |
@xabbuh but to do what? I can't see anything wrong (and I understand that @weaverryan doesn't understand it too) |
@wouterj The issue is that we currently say that you can create options with optional values. However, if you call a command with such an option without a value, you'll retrieve |
Ah, now I get it. Thanks for clarifying, @xabbuh . Tagging it with actionable and easy pick in that case :) |
…viereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Reworded the explanation about optional command options | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #4110 Commits ------- 89029cd Reworded again the note about "optional options" 221597a Reworded the explanation about "optional options" 1b5fcf0 Reworded the explanation about optional command options
This feature seems to be missing/not working as expected:
http://symfony.com/doc/current/components/console/introduction.html#using-command-options
While it's true you can specifiy --yell or yell=loud, it looks like you can't meaningfully distinguish between the two:
symfony/symfony#11572
Over on that issue they seem to think it's not really a symfony bug (or not a fixable one) and that maybe it's a documentation bug?
The text was updated successfully, but these errors were encountered: