[Cookbook][Security] Clarification on the the use of Voter::supportsClass

[bystones]

Hello,
I noticed that the cookbook (http://symfony.com/doc/master/cookbook/security/voters_data_permission.html#creating-the-custom-voter) uses instanceof in the supportsClass method even though the api states that the parameter $class is a string (http://api.symfony.com/master/Symfony/Component/Security/Core/Authorization/Voter/VoterInterface.html#method_supportsClass).
I'm now unsure if the cookbook is wrong and hope you can clarify and/or correct it.

Greetings

[bicpi]

👍 I also noticed this recently.

As PHP does not support scalar type hints it is not possible to force the paramater to be a string. But I think this should be changed as @bystones proposed so that it fits the API instead of passing an object and using instanceof - even if it gives the same result in the end.

[weaverryan]

Oh yes, that's indeed wrong.

Instead, it should look something like the supportsClass implementation here: http://symfony.com/doc/master/cookbook/security/entity_provider.html#authenticating-someone-with-a-custom-entity-provider

[weaverryan]

And there was already a PR to fix this!