Skip to content

Documenting all missing options #2362

Closed
@wouterj

Description

@wouterj
Member

The Form Type Reference has some missing options.

How to document it

Most of the missing options are already documented. You should check in the reference/forms/types/options/ directory to find if the option is already documented and if the description is correct for this type. If it is, you should add an include statement in the type reference article:

.. include:: /reference/forms/types/options/read_only.rst.inc

If the description is not correct for this type, you need to document it in the type reference article:

error_bubbling
~~~~~~~~~~~~~~
**type**: ``boolean`` **default**: ``false``

    
Some description and usage of the type.

If there is no documentation about the option and it is used in other types, you should create a new file in the reference/forms/types/options/ directory and include it in the relevant articles.

The Missing Options in 2.0

The options are all linked to the place where they are defined in the core code. However, search in the class to find some usage and other important information about the option you're documenting.

DateTime

  • ()

Field

    • the option should get removed

Form

Integer

  • (the docs already exists in the Number type, just create a and include it in both)

Time

Activity

xabbuh

xabbuh commented on Nov 4, 2013

@xabbuh
Member

Meanwhile (7e06f9f), the following options have been documented:

  • DateTime
    • empty_value
  • Integer
    • precision
  • Number
    • precision
  • Time
    • empty_value
wouterj

wouterj commented on Nov 4, 2013

@wouterj
MemberAuthor

thanks @xabbuh, updated the PR

xabbuh

xabbuh commented on Nov 4, 2013

@xabbuh
Member

What do we do with the Field options as it is not part of Symfony since 2.1?

stof

stof commented on Nov 4, 2013

@stof
Member

@xabbuh they are part of Symfony, but in the form type

xabbuh

xabbuh commented on Nov 4, 2013

@xabbuh
Member

I know. I think my question was not clear enough. I'm wondering if this list also applies to the FormType? Specifically, why should the disabled option be removed?

wouterj

wouterj commented on Nov 4, 2013

@wouterj
MemberAuthor

@xabbuh disabled was added in 2.1, not 2.0.

This list does not fully apply to 2.1.

xabbuh

xabbuh commented on Nov 4, 2013

@xabbuh
Member

So that's not a problem anymore.

I'll walk through the list one by one and will provide an updated list.

stof

stof commented on Nov 4, 2013

@stof
Member

@wouterj for 2.0, disabled was the same option than read_only in 2.1+

xabbuh

xabbuh commented on Nov 4, 2013

@xabbuh
Member

The following options need to be documented:

  • data_class
  • empty_data
  • max_length
  • pattern
  • by_reference
  • error_bubbling
  • label
  • label_attr
  • compound
dorians

dorians commented on Dec 14, 2013

@dorians

I think some options are already documented. So it's an updated list:

  • data_class ()
    empty_data
    pattern
    by_reference
    label_attr ()
    compound ()

12 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FormactionableClear and specific issues ready for anyone to take them.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dorians@stof@wouterj@xabbuh

        Issue actions

          Documenting all missing options · Issue #2362 · symfony/symfony-docs