-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Webpack Encore] always show examples with npm #15575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We did that because, after evaluating both tools, we decided that Yarn worked much better (and faster) than npm. But yes, we should display both commands always. So, someone with enough experience in "npm" needs to help us submitting a Pull Request with the needed changes. If there are lots of changes, it's OK to do separate PRs. Also, PRs should be created against 4.4 branch. Thanks! |
Hi I'm new :D but I'd like to help. Is this format OK?
|
I think it's better if we can use tabs but I don't know if this is possible with console code |
What about something like this?
There is a list of supported formats here which I don't know where these markup formats are defined. |
just use terminal for both code blocks |
This PR was merged into the 4.4 branch. Discussion ---------- resolves #15575 Add npm equivalent of yarn commands in separate tabs. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Commits ------- b9cfe08 resolves #15575 add npm equivalent of yarn commands in a separate code block.
* 4.4: resolves symfony#15575 add npm equivalent of yarn commands in a separate code block.
* 5.3: resolves symfony#15575 add npm equivalent of yarn commands in a separate code block.
* 5.4: resolves symfony#15575 add npm equivalent of yarn commands in a separate code block.
Is there any reason to favor
yarn
overnpm
command lines in webpack encore documentation?Some examples in the documentation are only available with yarn command and the installation example with npm is in the section "for non Symfony applications" so people may think that installing yarn is required when using Symfony.
I dont know if the documentation website supports it for command lines, but I think it could be nice to have all examples in both npm & yarn using the same tab feature we can see on some other pages (to switch between annotations, YAML, XML, ...)
And maybe display npm by default, because this is the tool required to install. Yarn is optional.
The text was updated successfully, but these errors were encountered: