Form collection has changed in 2.1

[tristanbes]

Behaviour of form collection has changed in 2.1 and is not reflected in the doc.

[weaverryan]

Hi Tristan!

Yes, we were just having this conversation at #1322 :). If we can verify that there are no other changes beyond the addXxx and removeXxx (the __name__ change is already there), then we can put some more specifics on this issue and make it actionable. So, if you know of any more specific changes, that would be great.!
Thanks!

[tristanbes]

Hi, Yes i'm aware that there are other changes for form collection with BC break :

symfony/symfony#4046

[tristanbes]

@weaverryan Do you have any updates on this ? It's quite important since the form collections are often used.

[weaverryan]

This issue is still valid. Specifically, we need to update the docs to mention the addXxx and removeXxx collection changes. This would need to be done in the form_collections doc, and then probably also mention it in the reference section for the collection, choice and entity types.

Thanks!

[wouterj]

@weaverryan do we need to update the documentation as said in upgrade-2.1.md? If so, I will take care of it.

EDIT: I read it to fast. Where can I find the differences?

[weaverryan]

The addXxx and removeXxx stuff is mentioned in the CHANGELOG here - https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/CHANGELOG.md.

It's a small change, but will mean some somewhat large changes to the form_collections doc. If you'd like to make those changes, that would be awesome :). The form_collections doc is one spot where I usually actually put together some test code to make sure everything is actually working, since there are so many pieces that work together.

Thanks!

[wouterj]

@weaverryan I don't understand what's missing (I'm not familiar with the Form Component), sorry. I will take a look on the Twig reference page and someone else can do this.

[weaverryan]

no problem :)

[weaverryan]

Basically we're still just missing specifics on the addXxx and removeXxx methods, but the collection document works on both 2.0 and 2.1.

So, once we have the addXxx and removeXxx stuff documented, then we can close this. I think this is needed in the choice, collection and entity form field references docs, possibly just one little example highlighting how this works that's included in all 3 of those docs.

[weaverryan]

Bernhard has already done the work for this in #1057, which explains the addXxx and removeXxx functionality. I'll close this issue in favor of that one, which is specific.