Skip to content

docs: Updated button width in documentation/reactivity #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

mayankjain25
Copy link
Contributor

@mayankjain25 mayankjain25 commented Jul 3, 2023

Fixed button width in order to avoid the changing width of the button in the result when the text changes from 'time' to 'times'

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Fixed button width in order to avoid the changing width of the button in the result when the text changes from 'time' to 'times'
@mayankjain25 mayankjain25 changed the title Updated button width in documentation/reactivity docs: Updated button width in documentation/reactivity Jul 3, 2023
@@ -5,7 +5,11 @@
// event handler code goes here
}
</script>

<style>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this change! A few things:

  • Can you use prettier extension if you are using VSCode.
  • <style> block is supposed to be at the bottom of the file, after the markup finishes.
  • App.svelte in app-b folder needs to be updated with the same change as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! Have made the required changes as needed. Would request you to go through it.

@mayankjain25
Copy link
Contributor Author

Thanks for approving! Is the PR good enough to be merged?

@PuruVJ PuruVJ merged commit d8a381e into sveltejs:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants