Skip to content

Add style to distinguish button disabled state #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AsafAgranat
Copy link

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Rich-Harris
Copy link
Member

Thank you! I agree with this change, but I reckon it probably makes sense for it to be built in to the default stylesheet, rather than specific to this example — so I've updated sveltejs/template instead, which also updates the tutorials (or will when I redeploy the site)

@AsafAgranat
Copy link
Author

I thought exactly that on the next instance I encountered a disabled button in the tutorial, but was too engrossed in the tutorials to do something about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants