switch from unpkg to jsdelivr #1244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Actually I take back point 2, we can use the same mechanism we currently use (fetching the package.json and resolving from that). So it's only really the directory imports, which we can choose to solve or not. If we choose to solve it, we can use the jsDelivr API. I think there might be a better alternative though — PR incoming |
3 tasks
|
closing in favour of #1248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces unpkg.com with jsdelivr.com, which is actively maintained and seems somewhat more robust (I've been experiencing a lot of issues with unpkg recently and I'm apparently not alone).
At least in local testing, jsDelivr also seems faster. However:
...doesn't work, because it should be
./components/index.js. Personally I'm not too concerned about this — packages should contain valid imports.sveltebut notsvelte/legacy, for example — it doesn't appear to handlepkg.exportscorrectly. Appending/+esmto pathnames results in a 200 response, but not one we can use (it bundles stuff in a way that would break things).